Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce use of LocalDefId <-> HirId maps #90146

Merged
merged 9 commits into from
Jan 16, 2022
Merged

Conversation

cjgillot
Copy link
Contributor

This is an attempt to reduce the perf effect of #89278.
r? @ghost

@rust-log-analyzer

This comment has been minimized.

@rust-log-analyzer

This comment has been minimized.

@cjgillot
Copy link
Contributor Author

@bors try @rust-timer queue

@rust-timer
Copy link
Collaborator

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Oct 22, 2021
@bors
Copy link
Contributor

bors commented Oct 22, 2021

⌛ Trying commit 437652f1641a199a4822f756bf3ce86f7bbfea49 with merge ba6244813e20a79c9f865108e1add3078beb8799...

@bors
Copy link
Contributor

bors commented Oct 22, 2021

☀️ Try build successful - checks-actions
Build commit: ba6244813e20a79c9f865108e1add3078beb8799 (ba6244813e20a79c9f865108e1add3078beb8799)

@rust-timer
Copy link
Collaborator

Queued ba6244813e20a79c9f865108e1add3078beb8799 with parent 45b600c, future comparison URL.

@rust-timer
Copy link
Collaborator

Finished benchmarking commit (ba6244813e20a79c9f865108e1add3078beb8799): comparison url.

Summary: This change led to large relevant mixed results 🤷 in compiler performance.

  • Large improvement in instruction counts (up to -2.3% on incr-patched: minor change builds of tokio-webpush-simple)
  • Large regression in instruction counts (up to 2.7% on incr-unchanged builds of match-stress-enum)

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR led to changes in compiler perf.

Next Steps: If you can justify the regressions found in this try perf run, please indicate this with @rustbot label: +perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please fix the regressions and do another perf run. If the next run shows neutral or positive results, the label will be automatically removed.

@bors rollup=never
@rustbot label: +S-waiting-on-review -S-waiting-on-perf +perf-regression

@rustbot rustbot added perf-regression Performance regression. S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-perf Status: Waiting on a perf run to be completed. labels Oct 22, 2021
@rust-log-analyzer

This comment has been minimized.

@cjgillot
Copy link
Contributor Author

@bors try @rust-timer queue

@rust-timer
Copy link
Collaborator

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Oct 27, 2021
@bors
Copy link
Contributor

bors commented Oct 27, 2021

⌛ Trying commit 6f4cc96 with merge 3c98d5fc58ff609ab72025df0586f8e61b4f96b1...

@bors
Copy link
Contributor

bors commented Oct 27, 2021

☀️ Try build successful - checks-actions
Build commit: 3c98d5fc58ff609ab72025df0586f8e61b4f96b1 (3c98d5fc58ff609ab72025df0586f8e61b4f96b1)

@rust-timer
Copy link
Collaborator

Queued 3c98d5fc58ff609ab72025df0586f8e61b4f96b1 with parent dd757b9, future comparison URL.

@rust-timer
Copy link
Collaborator

Finished benchmarking commit (3c98d5fc58ff609ab72025df0586f8e61b4f96b1): comparison url.

Summary: This change led to large relevant mixed results 🤷 in compiler performance.

  • Large improvement in instruction counts (up to -2.3% on incr-patched: minor change builds of tokio-webpush-simple)
  • Large regression in instruction counts (up to 2.7% on incr-unchanged builds of match-stress-enum)

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR led to changes in compiler perf.

Next Steps: If you can justify the regressions found in this try perf run, please indicate this with @rustbot label: +perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please fix the regressions and do another perf run. If the next run shows neutral or positive results, the label will be automatically removed.

@bors rollup=never
@rustbot label: +S-waiting-on-review -S-waiting-on-perf +perf-regression

@rustbot rustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Oct 28, 2021
@camelid camelid added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 9, 2021
@bors
Copy link
Contributor

bors commented Nov 28, 2021

☔ The latest upstream changes (presumably #91230) made this pull request unmergeable. Please resolve the merge conflicts.

@bors
Copy link
Contributor

bors commented Jan 8, 2022

☔ The latest upstream changes (presumably #90639) made this pull request unmergeable. Please resolve the merge conflicts.

@nagisa
Copy link
Member

nagisa commented Jan 15, 2022

I'm happy to r=me this. Please rebase and squash the history a little before merging though.

@cjgillot
Copy link
Contributor Author

@bors r=nagisa

@bors
Copy link
Contributor

bors commented Jan 15, 2022

📌 Commit 8617ff0 has been approved by nagisa

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 15, 2022
@bors
Copy link
Contributor

bors commented Jan 15, 2022

⌛ Testing commit 8617ff0 with merge f9d61cd...

@bors
Copy link
Contributor

bors commented Jan 16, 2022

☀️ Test successful - checks-actions
Approved by: nagisa
Pushing f9d61cd to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Jan 16, 2022
@bors bors merged commit f9d61cd into rust-lang:master Jan 16, 2022
@rustbot rustbot added this to the 1.60.0 milestone Jan 16, 2022
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (f9d61cd): comparison url.

Summary: This change led to moderate relevant improvements 🎉 in compiler performance.

  • Moderate improvement in instruction counts (up to -2.4% on incr-patched: minor change builds of tokio-webpush-simple)

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

@rustbot label: -perf-regression

@cjgillot cjgillot deleted the no-id-map branch January 22, 2022 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants